gdk: Drop source_device argument from _gdk_display_device_grab_update()
authorCarlos Garnacho <carlosg@gnome.org>
Tue, 28 Jul 2020 21:00:02 +0000 (23:00 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Tue, 28 Jul 2020 23:27:51 +0000 (01:27 +0200)
It's just passed around and used nowhere.

gdk/broadway/gdkeventsource.c
gdk/gdkdisplay.c
gdk/gdkdisplayprivate.h
gdk/gdksurface.c
gdk/macos/gdkmacosdevice.c
gdk/wayland/gdkdevice-wayland.c
gdk/win32/gdkdevice-virtual.c
gdk/x11/gdkdisplay-x11.c

index ae3b38fab5e006aff1606e0fa19ba330ea7760e0..6fbea5712361ad36e63e7cf0d9bbad4b2b52eb94 100644 (file)
@@ -280,7 +280,6 @@ _gdk_broadway_events_got_input (GdkDisplay *display,
   case BROADWAY_EVENT_UNGRAB_NOTIFY:
     _gdk_display_device_grab_update (display,
                                      display_broadway->core_pointer,
-                                     display_broadway->pointer,
                                      message->base.serial);
     break;
 
index 92f1de8a187f3544a68d3b420b61975779b71ee7..cc9306eafd2df49ba51883ecbcfa6d2084d55cf6 100644 (file)
@@ -603,7 +603,6 @@ get_current_toplevel (GdkDisplay      *display,
 static void
 switch_to_pointer_grab (GdkDisplay        *display,
                         GdkDevice         *device,
-                        GdkDevice         *source_device,
                        GdkDeviceGrabInfo *grab,
                        GdkDeviceGrabInfo *last_grab,
                        guint32            time,
@@ -680,7 +679,6 @@ _gdk_display_update_last_event (GdkDisplay     *display,
 void
 _gdk_display_device_grab_update (GdkDisplay *display,
                                  GdkDevice  *device,
-                                 GdkDevice  *source_device,
                                  gulong      current_serial)
 {
   GdkDeviceGrabInfo *current_grab, *next_grab;
@@ -705,7 +703,7 @@ _gdk_display_device_grab_update (GdkDisplay *display,
          if (!current_grab->activated)
             {
               if (gdk_device_get_source (device) != GDK_SOURCE_KEYBOARD)
-                switch_to_pointer_grab (display, device, source_device, current_grab, NULL, time, current_serial);
+                switch_to_pointer_grab (display, device, current_grab, NULL, time, current_serial);
             }
 
          break;
@@ -733,7 +731,7 @@ _gdk_display_device_grab_update (GdkDisplay *display,
       g_hash_table_insert (display->device_grabs, device, grabs);
 
       if (gdk_device_get_source (device) != GDK_SOURCE_KEYBOARD)
-        switch_to_pointer_grab (display, device, source_device,
+        switch_to_pointer_grab (display, device,
                                 next_grab, current_grab,
                                 time, current_serial);
 
index 13decb82bee8fe9626bce69013951d7609961378..7bdc5fc6baa00d835929207412a434facac4e837 100644 (file)
@@ -179,7 +179,6 @@ void                _gdk_display_update_last_event    (GdkDisplay     *display,
                                                        GdkEvent       *event);
 void                _gdk_display_device_grab_update   (GdkDisplay *display,
                                                        GdkDevice  *device,
-                                                       GdkDevice  *source_device,
                                                        gulong      current_serial);
 GdkDeviceGrabInfo * _gdk_display_get_last_device_grab (GdkDisplay *display,
                                                        GdkDevice  *device);
index 6b58c1f027205de9fc12308f185909ebe877842a..9edb3597b97cbe01bee85e908fe5dd891d50440d 100644 (file)
@@ -2244,7 +2244,7 @@ _gdk_windowing_got_event (GdkDisplay *display,
             source_device = pointer_info->last_physical_device;
         }
 
-      _gdk_display_device_grab_update (display, device, source_device, serial);
+      _gdk_display_device_grab_update (display, device, serial);
     }
 
   event_surface = gdk_event_get_surface (event);
@@ -2272,8 +2272,7 @@ _gdk_windowing_got_event (GdkDisplay *display,
                                         serial,
                                         gdk_event_get_time (event),
                                         TRUE);
-          _gdk_display_device_grab_update (display, device,
-                                           source_device, serial);
+          _gdk_display_device_grab_update (display, device, serial);
         }
     }
   else if (type == GDK_BUTTON_RELEASE ||
@@ -2292,7 +2291,7 @@ _gdk_windowing_got_event (GdkDisplay *display,
             {
               button_release_grab->serial_end = serial;
               button_release_grab->implicit_ungrab = FALSE;
-              _gdk_display_device_grab_update (display, device, source_device, serial);
+              _gdk_display_device_grab_update (display, device, serial);
             }
         }
     }
index 93a909c4c2d5d6d3d7c000a603807415841e756b..94ecbd4041dc2bc0bc27fa0ac2b3cbb7683e0a1f 100644 (file)
@@ -123,7 +123,7 @@ gdk_macos_device_ungrab (GdkDevice *device,
   if (grab != NULL)
     grab->serial_end = 0;
 
-  _gdk_display_device_grab_update (display, device, device, 0);
+  _gdk_display_device_grab_update (display, device, 0);
 }
 
 static void
index 0b1804648e3284f7df4f4a15bfdf04e3eaeacfdf..b6aa066773020353a658b446130254547acb5191 100644 (file)
@@ -1515,7 +1515,6 @@ pointer_handle_leave (void              *data,
                                     display_serial, NULL, TRUE);
       _gdk_display_device_grab_update (seat->display,
                                        seat->logical_pointer,
-                                       seat->pointer,
                                        display_serial);
     }
 
index d5f6b91644d386251b4d7a8024cbf67b761990b8..cff071de1b0013984edae982a2792e357b7356ef 100644 (file)
@@ -151,7 +151,7 @@ gdk_device_virtual_ungrab (GdkDevice *device,
       ReleaseCapture ();
     }
 
-  _gdk_display_device_grab_update (display, device, device, 0);
+  _gdk_display_device_grab_update (display, device, 0);
 }
 
 static void
index 8be698fa6efffd86f448c0e947f0fa0a7022901a..1c30c89e4015d77354060c983bf094860e638e91 100644 (file)
@@ -1760,15 +1760,9 @@ device_grab_update_callback (GdkDisplay *display,
                              gpointer    data,
                              gulong      serial)
 {
-  GdkPointerSurfaceInfo *pointer_info;
   GdkDevice *device = data;
 
-  pointer_info = _gdk_display_get_pointer_info (display, device);
-  _gdk_display_device_grab_update (display, device,
-                                   pointer_info->last_physical_device != NULL
-                                     ? pointer_info->last_physical_device
-                                     : device,
-                                   serial);
+  _gdk_display_device_grab_update (display, device, serial);
 }
 
 #define XSERVER_TIME_IS_LATER(time1, time2)                        \